Logs for #nikola for 2024-02-20

13:59:54 <KwBot> [nikola] aknrdureegaesr opened pull request #3760 (aknrdureegaesr:template_improvements): Template improvements https://github.com/getnikola/nikola/pull/3760
13:59:54 <KwBot_> [nikola] aknrdureegaesr opened pull request #3760 (aknrdureegaesr:template_improvements): Template improvements https://github.com/getnikola/nikola/pull/3760
14:12:57 <omwb> In my "template improvement" work, I found a lot of typing hints that were timid - they way they had to be with old Python versions. I streamlined those I happened to stumble over, mostly ones that I needed to read while comprehending what is going on. Now, the 3.8 tests fail in earnest. (Good ridance.)
14:15:42 <omwb> But the Python 3.8 tests are still configured as "required".
14:41:42 <omwb> Ah, shit! I was confused! We still support 3.8 and only got rid of 3.7, right? :-!
15:04:59 <omwb> Right.
15:19:43 <omwb> TIL: On my trusted old machine, which predates the original Python 3.8 release by four years almost to the day, Python 3.8's  ./configure && make && make test takes 20 minutes. :-D
15:39:12 <omwb> That fix was much more trivial than I had been afraid it would be. All tests green. Reviewers: https://github.com/getnikola/nikola/pull/3760 "Template improvements" may be reviewed now.
17:33:59 <KwBot> [nikola] aknrdureegaesr opened issue #3761: nikola auto: "AttributeError: 'FileOpenedEvent' object has no attribute '_src_path'. Did you mean: 'src_path'?" https://github.com/getnikola/nikola/issues/3761
17:33:59 <KwBot_> [nikola] aknrdureegaesr opened issue #3761: nikola auto: "AttributeError: 'FileOpenedEvent' object has no attribute '_src_path'. Did you mean: 'src_path'?" https://github.com/getnikola/nikola/issues/3761
17:52:15 <KwBot> [nikola] aknrdureegaesr opened pull request #3762 (getnikola:watchdog_new_major_version): Port to new major (incompatible) version of watchdog. Fixes #3761. https://github.com/getnikola/nikola/pull/3762
17:52:15 <KwBot_> [nikola] aknrdureegaesr opened pull request #3762 (getnikola:watchdog_new_major_version): Port to new major (incompatible) version of watchdog. Fixes #3761. https://github.com/getnikola/nikola/pull/3762
17:58:11 <omwb> All test are green on #3762. Estimated time for review: 5 minutes or less.