Logs for #nikola for 2018-03-13

13:03:26 -GitHub[nikola]:#nikola- [nikola] ralsina pushed 1 new commit to master: https://git.io/vxUmw
13:03:26 -GitHub[nikola]:#nikola- nikola/master 5a2d2f4 Roberto Alsina: Add a reasonable self.logger to all plugins (#2977)...
13:11:01 -travis-ci:#nikola- getnikola/nikola#9678 (master - 5a2d2f4 : Roberto Alsina): The build passed.
13:11:02 -travis-ci:#nikola- Change view: https://github.com/getnikola/nikola/compare/8b2034f9ac01...5a2d2f49b27a
13:11:02 -travis-ci:#nikola- Build details: https://travis-ci.org/getnikola/nikola/builds/352826523
14:01:04 -GitHub[nikola]:#nikola- [nikola] ralsina created commento (+2 new commits): https://git.io/vxUcL
14:01:05 -GitHub[nikola]:#nikola- nikola/commento 6250231 Roberto Alsina: Initial untested commento support
14:01:05 -GitHub[nikola]:#nikola- nikola/commento 6539975 Roberto Alsina: Fix so it works with latest docker image
14:01:30 -GitHub[nikola]:#nikola- [nikola] ralsina opened pull request #2978: Support for Commento (Issue #2773) (master...commento) https://git.io/vxUcm
14:11:39 <KwBot> [nikola] ralsina opened issue #2979: Add support for Schnack comments https://github.com/getnikola/nikola/issues/2979
20:47:28 <berti_> hmmm
20:48:44 <berti_> just pulled from upstream, updated requirements including doit 0.31.0 and now I get a wired error message
20:49:00 <berti_> ...  File "/home/michael/.virtualenvs/env_v8_nikola/lib/python3.5/site-packages/doit/cmd_clean.py", line 109, in _execute
20:49:00 <berti_>     self.clean_tasks(to_clean, dryrun, cleanforget)
20:49:00 <berti_> TypeError: clean_tasks() takes 3 positional arguments but 4 were given
20:49:00 <berti_> Scanning posts........done!
20:49:43 <ralsina> berti_: hmmm
20:49:58 <ralsina> may be a change in latest doit, let me check
20:51:19 <ralsina> berti_: same here
20:51:32 <ralsina> looks like 0.31 breaks that. You can downgade to 0.30.1 and it should work
20:51:45 <berti_> OK, will do that
20:55:33 <ChrisWarrick> would be nice to fix this
20:55:44 <ralsina> I'm looking into it
20:55:47 <ralsina> it's tricky
20:59:08 <ralsina> Ok, I can fix it but we wil start requiring 0.31
21:00:30 -GitHub[nikola]:#nikola- [nikola] ralsina created fix-doit-clean (+1 new commit): https://git.io/vxTnB
21:00:30 -GitHub[nikola]:#nikola- nikola/fix-doit-clean 1312b07 Roberto Alsina: Use doit clean as required by doit 0.31
21:02:25 <ralsina> Nah, I made it work on both
21:02:26 -GitHub[nikola]:#nikola- [nikola] ralsina pushed 1 new commit to fix-doit-clean: https://git.io/vxTnS
21:02:26 -GitHub[nikola]:#nikola- nikola/fix-doit-clean 4059d2e Roberto Alsina: Fix that works with both doit 0.30.1 and 0.31
21:03:01 <ralsina> berti_, ChrisWarrick ^
21:03:05 -GitHub[nikola]:#nikola- [nikola] ralsina opened pull request #2980: Fix doit clean (master...fix-doit-clean) https://git.io/vxTn5
21:03:10 <ralsina> Or rather ^
21:05:17 <berti_> testing required?
21:07:44 <ralsina> Well, I sort of tested it
21:07:59 <ralsina> but if you want the patch soon instead of downgrading doit, that's one way to do it :-)
21:08:16 <berti_> downgrading solved it
21:10:22 <berti_> but fix-doit-clean works for me as well with doit 0.31.0. thx ;-)
21:11:22 <ralsina> cool :-)
21:12:52 -GitHub[nikola]:#nikola- [nikola] ralsina pushed 1 new commit to fix-doit-clean: https://git.io/vxTCY
21:12:52 -GitHub[nikola]:#nikola- nikola/fix-doit-clean d18726d Roberto Alsina: Added comment
21:13:13 -GitHub[nikola]:#nikola- [nikola] ralsina closed pull request #2980: Fix doit clean (master...fix-doit-clean) https://git.io/vxTn5
21:13:14 <ralsina> Thx for the review @ChrisWarrick
21:13:18 <ChrisWarrick> yw
21:41:55 -travis-ci:#nikola- getnikola/nikola#9684 (fix-doit-clean - d18726d : Roberto Alsina): The build passed.
21:41:56 -travis-ci:#nikola- Change view: https://github.com/getnikola/nikola/compare/4059d2e32bda...d18726d75b9d
21:41:56 -travis-ci:#nikola- Build details: https://travis-ci.org/getnikola/nikola/builds/353056063
21:56:22 -travis-ci:#nikola- getnikola/nikola#9686 (master - a976064 : Roberto Alsina): The build passed.
21:56:23 -travis-ci:#nikola- Change view: https://github.com/getnikola/nikola/compare/5a2d2f49b27a...a97606400f97
21:56:23 -travis-ci:#nikola- Build details: https://travis-ci.org/getnikola/nikola/builds/353056265